Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condor fixes #289

Merged
merged 2 commits into from May 28, 2015
Merged

Condor fixes #289

merged 2 commits into from May 28, 2015

Conversation

dpryan79
Copy link
Contributor

These modifications to the HTCondor job runner put it in line with the DRMAA job runner and fix this issue on the trello board. In short, the runner now looks for an appropriate embed_metadata_in_job param in job_conf.xml. If it finds it and the value is False, then metadata will be set locally after a job has successfully finished. If the value is True or the parameter doesn't exist, then the default is to have the remote node attempt to set the metadata.

For my own use, it would be more convenient for embed_metadata_in_job to default to False, but since the other job runners default to True it's probably best to keep things the same.

@jmchilton
Copy link
Member

👍 This seems like a fine workaround until Galaxy becomes more competent at metadata handling - Pulsar and the local job runner have similar configuration switches.

jmchilton added a commit that referenced this pull request May 28, 2015
@jmchilton jmchilton merged commit 5949abb into galaxyproject:dev May 28, 2015
@dpryan79 dpryan79 deleted the condor_fixes branch June 2, 2015 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants