Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change __all__ from list to tuple [1/2] #3041

Merged
merged 1 commit into from Oct 13, 2016
Merged

Change __all__ from list to tuple [1/2] #3041

merged 1 commit into from Oct 13, 2016

Conversation

nsoranzo
Copy link
Member

xref. #3004

Also fix import order and Python3 compatibility (xref. #1715 )

@nsoranzo
Change __all__ from list to tuple
77f78cf 
Also fix import order and Python3 compatibility.
@nsoranzo nsoranzo added this to the 16.10 milestone Oct 13, 2016
@dannon
Copy link
Member

dannon commented Oct 13, 2016 •
edited

I'll admit it feels a little weird to do this with __all__ being a list as fairly standard practice, but I don't see any usage of ours that'd break with the new immutability, tests pass, and I guess it allows easier linting.

@dannon dannon merged commit 277727a into galaxyproject:dev Oct 13, 2016
@nsoranzo nsoranzo added the area/python3 Specific to Python 3 label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/framework area/python3 Specific to Python 3 kind/enhancement
Projects
None yet
Milestone
16.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nsoranzo @dannon