Fix repeated error messages with identical text. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, one would see the same error message, e.g. with invalid tool dependencies, repeated approximately X * Y times, where X is approximately 6, and Y is the number of <action> tags in a tool dependency definition. This commit ameliorates that issue somewhat.
|
This is probably a part of the memory error here: https://trello.com/c/JzFBQ7S5/290-specifying-an-invalid-complex-tool-dependency-results-in-memory-error |
|
👍 |
|
Good enough for now -- should probably be handled as list of messages instead of a concatenated string. |
blankenberg
added a commit
that referenced
this pull request
Jun 12, 2015
Fix repeated error messages with identical text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, one would see the same error message, e.g. with invalid tool dependencies, repeated approximately X * Y times, where X is around 6, and Y is the number of tags in a tool dependency definition. This commit ameliorates that issue somewhat.
There may be other instances where this kind of error occurs, and there may be a better solution.