Move thumbnail list view to shared ui elements, revise tabs, add test cases #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
reusable_grid_view
branch
from
3776434
to
05a41c2
Compare
guerler
force-pushed
the
reusable_grid_view
branch
from
05a41c2
to
ec9ca3f
Compare
guerler
changed the title
|
Looks great to me - always excited to see more test cases also! |
|
Thanks @jmchilton (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to reuse the thumbnail selector ui input element. It is currently only used to select chart types in charts. The PR also removes unused features from the underlying tab-element builder, revises it and adds several test cases for both components.