Restore XML formatting for tool schema document. #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone else is wondering what's the difference between code and code-block in rst files: https://stackoverflow.com/questions/34845889/whats-the-difference-between-the-code-and-code-block-directives-in-rest |
nsoranzo
reviewed
Nov 1, 2016
| $(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html | ||
| @echo | ||
| @echo "Build finished. The HTML pages are in $(BUILDDIR)/html." | ||
|
|
||
| html: $(GENERATED_RST) _html | ||
|
|
There was a problem hiding this comment.
I don't understand the changes to the html target, why is that needed?
Also, you'd need to add _html to the .PHONY targets.
There was a problem hiding this comment.
I reverted this part - I like that pattern because it allows me to test targets one at a time but maybe there is a better way to debug Makefile stuff?
There was a problem hiding this comment.
Debug Makefiles, is there such a thing? 😆
jmchilton
force-pushed
the
schema_build
branch
from
4bcdc84
to
ce1c7e4
Compare
|
Thanks @jmchilton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brokenish with #3086 - at least with the two versions of Sphinx I tried.