Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready Integration Testing for Prime Time #3291

Merged
merged 11 commits into from Dec 15, 2016
Merged

Ready Integration Testing for Prime Time #3291

merged 11 commits into from Dec 15, 2016

Commits on Dec 14, 2016

  1. Improved documentation and design of integration tests. 

    - Allow running through ``run_tests.sh``.
- Enable more verbose test errors for Conda tests.
- Refactor how integration tests depend on API testing (use a Mixin instead of subclassing conceptually conflicting TestCase classes).
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    ac581a5 View commit details
    Browse the repository at this point in the history

  2. Fix Jenkins script test for integration tests.

    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    00c6ee1 View commit details
    Browse the repository at this point in the history

  3. Integration test for advanced job runner stuff. 

    Set of test cases that cover job resource handlers and resubmit job destinations.
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    b78287f View commit details
    Browse the repository at this point in the history

  4. Implement resubmit on unknown failures.

    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    0559cff View commit details
    Browse the repository at this point in the history

  5. Allow expressions in job_conf resubmission conditions. 

    Since we allow dynamic job runners clearly job_conf.xml must be considered a trusted document. Still I know that some are uneasy with eval generally so I only allow a very safe subset of Python expressions in this job_conf document.
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    7d52b28 View commit details
    Browse the repository at this point in the history

  6. Fix preservation of resubmits for resubmitted jobs. 

    Create an abstraction for the explicit handling of resubmits that is done during job recovery at startup.

xref galaxyproject@5539a08
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    949d122 View commit details
    Browse the repository at this point in the history

  7. Add attempt to resubmission expression language.

    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    7e338d7 View commit details
    Browse the repository at this point in the history

  8. Add a self re-submission test.

    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    325b035 View commit details
    Browse the repository at this point in the history

  9. Add seconds_running and seconds_since_queued to condition expression … 

    …langauge.
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    18eb1c8 View commit details
    Browse the repository at this point in the history

  10. Allow (and test) using expressions in job re-submission delays. 

    So you can backoff re-submission with ``delay="attempt * 30"`` for instance - which will cause a re-submission delay to increase by 30 seconds for each resubmission of a job.
    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    334dfe1 View commit details
    Browse the repository at this point in the history

  11. Two lint fixes for galaxyproject#3291.

    @jmchilton
    jmchilton committed Dec 14, 2016
    Copy the full SHA
    521a585 View commit details
    Browse the repository at this point in the history