Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve routing for user preference views #3446

Merged
merged 35 commits into from Mar 15, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jan 18, 2017

During our last meeting @dannon and I talked about how to improve the handling of routes going forward. As a case, we picked the user preference interface. This PR separates the condensed preference view module into three components. A main panel view, a view rendering individual preference forms and a model with form details. Additionally, it adds client routes to individual preference forms. Fixes #3647.

@guerler guerler added this to the 17.05 milestone Jan 18, 2017

@guerler guerler requested a review from dannon Jan 18, 2017

@guerler guerler force-pushed the guerler:ui_pref_routing branch from 8def5b7 to 365c56f Feb 23, 2017

@guerler guerler added the kind/bug label Feb 25, 2017

@guerler guerler force-pushed the guerler:ui_pref_routing branch from fd72884 to 8a8603b Feb 25, 2017

@guerler guerler force-pushed the guerler:ui_pref_routing branch from 29423ff to f0b03a5 Mar 1, 2017

@dannon dannon referenced this pull request Mar 14, 2017

Merged

Bump routes to 2.4.1 #3752

@guerler guerler added status/review and removed status/WIP labels Mar 14, 2017

@dannon
Copy link
Member

left a comment

+1, nice incremental improvements that we can keep building on.

@dannon dannon merged commit 0498c7f into galaxyproject:dev Mar 15, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.