Improve routing for user preference views #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
ui_pref_routing
branch
from
8def5b7
to
365c56f
Compare
guerler
force-pushed
the
ui_pref_routing
branch
from
fd72884
to
8a8603b
Compare
User->Users
Ui pref routing
…upon multiple navigation requests
…tion, and we wat the default
Don't have the clientside mapper register itself
Merged
dannon
reviewed
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our last meeting @dannon and I talked about how to improve the handling of routes going forward. As a case, we picked the user preference interface. This PR separates the condensed preference view module into three components. A main panel view, a view rendering individual preference forms and a model with form details. Additionally, it adds client routes to individual preference forms. Fixes #3647.