Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] Fix problem with cleaning up jobs in local runner. #3803

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
5 participants
@jmchilton
Copy link
Member

commented Mar 22, 2017

Fixes #3801 (broken in b78287f as part of #3291).

@@ -427,6 +429,19 @@ def default_job_file( files_dir, id_tag ):
def default_exit_code_file( files_dir, id_tag ):
return os.path.join( files_dir, 'galaxy_%s.ec' % id_tag )

def cleanup( self ):
for file in [ getattr( self, a ) for a in self.cleanup_file_attributes if hasattr( self, a ) ]:

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 22, 2017

Member

Not needed for this PR, but it would be nice to use another variable name instead of file which is a standard library function in Python2.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Mar 22, 2017

Author Member

Agreed completely - next time I'm in there to clean up that TODO I added I'll try to remember to fix this as well.

@blankenberg blankenberg merged commit 65cbdde into galaxyproject:release_17.01 Mar 22, 2017

5 checks passed

api test Build finished. 257 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 136 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Mar 22, 2017

This PR was merged without a milestone attached.

@jmchilton jmchilton added this to the 17.01 milestone Mar 22, 2017

@martenson martenson modified the milestones: 17.05, 17.01 Mar 22, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

@jmchilton after release for release branch new things please target the next milestone, se we have it in release notes somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.