Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to improve the robustness and verboseness of the test_sharing_valid Selenium test. #3841

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Attempt to improve the robustness and verboseness of the test_sharing_valid Selenium test. #3841

merged 1 commit into from
Mar 29, 2017

Conversation

jmchilton
Copy link
Member

  • When registering, put a little pause in after clicking to ensure the browser has a chance to submit the request before continuing to check if indeed the user is logged in.
  • If the user doesn't appear to be logged in, dump the contents of the user menu out so we can see if a different user is logged in or if there is no log in.
  • Attempt to be more robust about conditions being waited on when clicking history option menu - in case clicks were being fired during jQuery transitions or something.

xref #3838

@jmchilton
Attempt to improve the robustness and verboseness of the test_sharing…
11860d5 
…_valid Selenium test.

- When registering, put a little pause in after clicking to ensure the browser has a chance to submit the request before continuing to check if indeed the user is logged in.
- If the user doesn't appear to be logged in, dump the contents of the user menu out so we can see if a different user is logged in or if there is no log in.
- Attempt to be more robust about conditions being waited on when clicking history option menu - in case clicks were being fired during jQuery transitions or something.

xref galaxyproject#3838
@jmchilton jmchilton added this to the 17.05 milestone Mar 29, 2017
@martenson martenson merged commit 10e89cf into galaxyproject:dev Mar 29, 2017
@martenson
Copy link
Member

Thanks for improving these @jmchilton !

@galaxybot
Copy link
Contributor

This PR was merged without a 'kind/' tag, please correct.

@martenson martenson deleted the selenium_fixes_7 branch March 26, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing area/UI-UX kind/enhancement
Projects
None yet
Milestone
17.05
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmchilton @martenson @galaxybot