Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve the robustness and verboseness of the test_sharing_valid Selenium test. #3841

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Mar 29, 2017

  • When registering, put a little pause in after clicking to ensure the browser has a chance to submit the request before continuing to check if indeed the user is logged in.
  • If the user doesn't appear to be logged in, dump the contents of the user menu out so we can see if a different user is logged in or if there is no log in.
  • Attempt to be more robust about conditions being waited on when clicking history option menu - in case clicks were being fired during jQuery transitions or something.

xref #3838

Attempt to improve the robustness and verboseness of the test_sharing…
…_valid Selenium test.

- When registering, put a little pause in after clicking to ensure the browser has a chance to submit the request before continuing to check if indeed the user is logged in.
- If the user doesn't appear to be logged in, dump the contents of the user menu out so we can see if a different user is logged in or if there is no log in.
- Attempt to be more robust about conditions being waited on when clicking history option menu - in case clicks were being fired during jQuery transitions or something.

xref #3838

@jmchilton jmchilton added this to the 17.05 milestone Mar 29, 2017

@martenson martenson merged commit 10e89cf into galaxyproject:dev Mar 29, 2017

5 checks passed

api test Build finished. 271 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Thanks for improving these @jmchilton !

@galaxybot

This comment has been minimized.

Copy link

commented Mar 26, 2019

This PR was merged without a 'kind/' tag, please correct.

@martenson martenson deleted the jmchilton:selenium_fixes_7 branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.