Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.01] More careful inspection of fixes for MAF tools requiring Galaxy. #3935

Merged
merged 1 commit into from
May 2, 2017

Conversation

jmchilton
Copy link
Member

Add two tools that required the hack, and remove one tool that doesn't seem to require it. Tracked in comment on #3934.

Add two tools that required the hack, and remove one tool that doesn't seem to require it. Tracked in comment on galaxyproject#3934.
@nsoranzo
Copy link
Member

@jmchilton What about the bx imports? It seems to me that all maf tools should have a requirement on bx-python to properly work, especially the ones not on this list.

@jmchilton
Copy link
Member Author

maf_limit_size was removed from the list - its Python file imports are as follows:

from __future__ import print_function

import sys

import bx.align.maf

Since it doesn't import galaxy - I don't think it needs to be in the list. Galaxy's dependencies such as bx are still exposed to tools. A lot more would break I think if bx were to disappear.

@nsoranzo
Copy link
Member

nsoranzo commented May 2, 2017

I'll investigate the bx-python requirement issue separately.

@nsoranzo nsoranzo merged commit de46a0e into galaxyproject:release_17.01 May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants