Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Do not modify self.app.config.tool_data_path #4089

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented May 19, 2017

and self.app.config.tool_data_table_config_path during metadata setting.

xref galaxyproject/tools-iuc#1315.

I suspect multiple threads installing tool simultaneously may have led
to self.app.config.tool_data_path and/or
self.app.config.tool_data_table_config_path being set to a temporary
directory. Initial testing looks like this is not necessary.

Do not modify self.app.config.tool_data_path
and self.app.config.tool_data_table_config_path during metadata setting.

xref galaxyproject/tools-iuc#1315.

I suspect multiple threads installing tool simultaneously may have led
to self.app.config.tool_data_path and/or
self.app.config.tool_data_table_config_path being set to a temporary
directory. Initial testing looks like this is not necessary.

@mvdbeek mvdbeek added this to the 17.05 milestone May 19, 2017

@mvdbeek mvdbeek changed the title [17.05][WIP] Do not modify self.app.config.tool_data_path [17.05] Do not modify self.app.config.tool_data_path May 21, 2017

@mvdbeek mvdbeek added status/review and removed status/WIP labels May 21, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented May 21, 2017

I have gone through the various functions that are being called by generate_metadata_for_changeset_revision , and none are relying on a modified self.app.config.tool_data_table_config_path / self.app.config.tool_data_path, so this should be a safe change. Installing a new data manager and associated tables also worked fine. This is ready for review now.

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

Thank you @mvdbeek !

@martenson martenson merged commit 3d1da8e into galaxyproject:release_17.05 May 23, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request May 24, 2017

@mvdbeek mvdbeek deleted the mvdbeek:no_global_changes branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.