Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created alphabetic and numerical sort tool for collection operations #4329

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
5 participants
@glormph
Copy link
Contributor

commented Jul 21, 2017

This PR creates a new tool in collection operations, which can sort a collection of the list type on its element identifiers. Referred to in gitter: https://gitter.im/galaxyproject/Lobby?at=5971d67b1c8697534a47166c

It scratches an itch I have, because I have a lot of collection work and two collections sometimes need to be in sync with eachother e.g. when pairing them. When they are not sorted problems ensue (i.e. I have to do that via the API creating a new collection). Also when creating new collections the standard order I sometimes find backwards (file highest in history is first).

The tool is implemented as other collection operation tools, I more or less ripped the flatten_collection.xml and the functionality is in lib/galaxy/tools, so there is no impact on user quota.

I included two tests, which can be run using the functional framework tests: sh run_tests.sh -framework -id __SORTLIST__. Tests pass on my box (famous last words).

Hoping this is useful stuff for other people too.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

This is perfect! Very nice work @glormph - a wonderful contribution. I'm going to let the tests run and then merge if there are no problems.

@glormph

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2017

Happy you like it but now I think about it, why did I not implement a reverse sort while I was at it? Can look at that tomorrow, now 💤

@jmchilton jmchilton merged commit e3de5e2 into galaxyproject:dev Aug 10, 2017

4 of 5 checks passed

api test Build finished. 279 tests run, 0 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 152 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 10, 2017

Awesome - thanks @glormph!

@RJMW

This comment has been minimized.

Copy link

commented Aug 23, 2017

👍

glormph referenced this pull request in glormph/tools-galaxyp Aug 24, 2017

Started on multiple-DB-fraction work. Supposed to make possible to ru…
…n collection lists where each mzML has its own FASTA file. Eg for prefractionation experiments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.