Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent early dataset state changes in the ShellJobRunner #4343

Merged
merged 2 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Jul 25, 2017

This prevents a (rare) problem when running a workflow, where a downstream job
requires tool metadata from the previous job. Calling
job_wrapper.state_change() too early will cause the next job to run,
which will fail due to missing metadata. Note that other job runners do
not explicitly call job_wrapper.change_state() when the state is OK.

mvdbeek added some commits Jul 25, 2017

Prevent early dataset state changes
This prevents a (rare) problem when running a workflow, where a "step 2"
requires tool metadata from the output of "step 1". Calling
`job_wrapper.state_change()` too early will cause the next job to run,
which will fail due to missing metadata. Note that other job runners do
not explicitly call `job_wrapper.change_state()` when the state is OK.

@mvdbeek mvdbeek added this to the 17.09 milestone Jul 25, 2017

@jmchilton jmchilton merged commit e1c54f3 into galaxyproject:dev Jul 28, 2017

5 checks passed

api test Build finished. 279 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 150 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 37 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

Makes good sense - thanks for the fix @mvdbeek !

@mvdbeek mvdbeek deleted the mvdbeek:clirunner_fix_metadata branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.