Prevent early dataset state changes in the ShellJobRunner #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a (rare) problem when running a workflow, where a "step 2" requires tool metadata from the output of "step 1". Calling `job_wrapper.state_change()` too early will cause the next job to run, which will fail due to missing metadata. Note that other job runners do not explicitly call `job_wrapper.change_state()` when the state is OK.
|
Makes good sense - thanks for the fix @mvdbeek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a (rare) problem when running a workflow, where a downstream job
requires tool metadata from the previous job. Calling
job_wrapper.state_change()too early will cause the next job to run,which will fail due to missing metadata. Note that other job runners do
not explicitly call
job_wrapper.change_state()when the state is OK.