Slightly improve workflow warnings/errors logging. #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Aug 9, 2017
lib/galaxy/workflow/modules.py
Outdated
| @@ -965,7 +977,7 @@ def from_dict( self, trans, d, **kwargs ): | |||
| Return module initialized from the data in dictionary `d`. | |||
| """ | |||
| type = d['type'] | |||
| assert type in self.module_types | |||
| assert type in self.module_types, "Unexpected workflow step type [%s] not found in [%s]"% (type, self.module_types.keys()) | |||
There was a problem hiding this comment.
lib/galaxy/workflow/modules.py:980:97: E225 missing whitespace around operator
nsoranzo
reviewed
Aug 9, 2017
lib/galaxy/workflow/modules.py
Outdated
| @@ -810,6 +810,9 @@ def execute( self, trans, progress, invocation, step ): | |||
| # TODO: Move next step into copy() | |||
| execution_state.inputs = make_dict_copy( execution_state.inputs ) | |||
|
|
|||
| expected_replacement_keys = set(step.input_connections_by_name.keys()) | |||
| found_replacement_keys = set([]) | |||
There was a problem hiding this comment.
set() should be equivalent to set([])
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Aug 9, 2017
jmchilton
force-pushed
the
workflow_warnings
branch
from
f71a000
to
7bf7f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More small usability improvements from the CWL branch.