Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve workflow warnings/errors logging. #4396

Merged
merged 3 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Aug 9, 2017

  • Better assertion message for unknown module types.
  • Warn in the logs if an input connection is defined but unused while connecting up things for tool execution.

More small usability improvements from the CWL branch.

@@ -965,7 +977,7 @@ def from_dict( self, trans, d, **kwargs ):
Return module initialized from the data in dictionary `d`.
"""
type = d['type']
assert type in self.module_types
assert type in self.module_types, "Unexpected workflow step type [%s] not found in [%s]"% (type, self.module_types.keys())

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 9, 2017

Member

lib/galaxy/workflow/modules.py:980:97: E225 missing whitespace around operator

@@ -810,6 +810,9 @@ def execute( self, trans, progress, invocation, step ):
# TODO: Move next step into copy()
execution_state.inputs = make_dict_copy( execution_state.inputs )

expected_replacement_keys = set(step.input_connections_by_name.keys())
found_replacement_keys = set([])

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Aug 9, 2017

Member

set() should be equivalent to set([])

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Aug 9, 2017

@jmchilton jmchilton force-pushed the jmchilton:workflow_warnings branch from f71a000 to 7bf7f39 Aug 17, 2017

@nsoranzo nsoranzo merged commit 784e6f5 into galaxyproject:dev Aug 18, 2017

6 checks passed

api test Build finished. 281 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 153 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.