Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored a dataset variable to hda #4630

Merged
merged 1 commit into from Sep 16, 2017
Merged

Refactored a dataset variable to hda #4630

merged 1 commit into from Sep 16, 2017

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Sep 15, 2017

Actually the dataset variable is of HistoryDatasetAssociation type, so it should be named correctly. Then we should not see the confusing dataset = dataset.dataset statement.

@galaxybot galaxybot added this to the 17.09 milestone Sep 15, 2017
@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes status/review and removed triage labels Sep 16, 2017
@jmchilton jmchilton merged commit 4c9cc67 into galaxyproject:dev Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VJalili @jmchilton @galaxybot