Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored a dataset variable to hda #4630

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
3 participants
@VJalili
Copy link
Member

commented Sep 15, 2017

Actually the dataset variable is of HistoryDatasetAssociation type, so it should be named correctly. Then we should not see the confusing dataset = dataset.dataset statement.

@galaxybot galaxybot added the triage label Sep 15, 2017

@galaxybot galaxybot added this to the 17.09 milestone Sep 15, 2017

@jmchilton jmchilton merged commit 4c9cc67 into galaxyproject:dev Sep 16, 2017

5 of 6 checks passed

toolshed test Build finished. 579 tests run, 0 skipped, 1 failed.
Details
api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.