New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mothur.freq sniffer more stringent #4781

Merged
merged 4 commits into from Oct 12, 2017

Conversation

Projects
None yet
4 participants
@yhoogstrate
Member

yhoogstrate commented Oct 10, 2017

yhoogstrate added some commits Oct 10, 2017

@galaxybot galaxybot added the triage label Oct 10, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 10, 2017

@nsoranzo

I also independently found the error at line 615, good catch!

@@ -582,6 +582,7 @@ def sniff(self, filename):
class Frequency(Tabular):
file_ext = 'mothur.freq'
max_snif_lines = 25

This comment has been minimized.

@nsoranzo

nsoranzo Oct 10, 2017

Member

You don't need to re-implement this, there's already a count parameter for iter_headers(), which by default is 60 lines.

@nsoranzo nsoranzo referenced this pull request Oct 10, 2017

Merged

edgeR #1471

@jmchilton jmchilton merged commit 5bf08cf into galaxyproject:dev Oct 12, 2017

6 checks passed

api test Build finished. 303 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment