Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighter weight Selenium test setup for PRs. #4925

Merged
merged 2 commits into from Nov 4, 2017
Merged

Lighter weight Selenium test setup for PRs. #4925

merged 2 commits into from Nov 4, 2017

Commits on Nov 3, 2017

  1. Lighter weight Selenium test setup for PRs. 

    The Dockerfile and image update in galaxyproject#4900 baked chrome, chrome-wrapper, xvfb, and a Selenium server into the default Galaxy testing image. This means we should no longer need to run three docker containers in a compose setup to run Selenium tests. This swaps the script target used by Jenkins to use this newer variant of the tests.

In addition to simply consuming less CPU and booting up much faster thanks to pre-installed dependencies and pre-migrated database, this setup is much easier to cleanup and so we don't need to restrict it to one test per host - these tests I think should run just like API and framework tests. This should also be easier for people running tests locally.

I've kept the old compose setup around and I'll setup a Jenkins job against dev that continues to run it periodically (just not on PRs). It does testing of proxy prefix things this variant doesn't and serves as a good reference implementation for multi-container Galaxy testing - which we may wish to do for various categories of tests in the future. The multi-container variant makes it much easier to bring in various services - lots of which one can imagine writing useful Galaxy tests for - AMQP, statistics collection, Docker itself, etc....
    @jmchilton
    jmchilton committed Nov 3, 2017
    Copy the full SHA
    c4a1ffa View commit details
    Browse the repository at this point in the history

  2. Fix published histories grid test.

    @jmchilton
    jmchilton committed Nov 3, 2017
    Copy the full SHA
    3a1ca26 View commit details
    Browse the repository at this point in the history