Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 client/galaxy/scripts/utils/ajax-queue.js #4933

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

jmchilton commented Nov 5, 2017

  • Use class, super, static, and constructor to clean up object declaration.
  • Eliminate self.
ES6 client/galaxy/scripts/utils/ajax-queue.js
- Use ``class``, ``super``, ``static``, and ``constructor`` to clean up object declaration.
- Eliminate ``self``.

@galaxybot galaxybot added the triage label Nov 5, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 5, 2017

@dannon

This comment has been minimized.

Copy link
Member

dannon commented Nov 6, 2017

Looks good to me!

@dannon dannon merged commit b8a33ed into galaxyproject:dev Nov 6, 2017

7 checks passed

api test Build finished. 307 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Nov 6, 2017

Thanks @dannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.