New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove html formbuilder from backend #5114

Merged
merged 95 commits into from Dec 11, 2017

Conversation

Projects
None yet
5 participants
@guerler
Contributor

guerler commented Dec 1, 2017

This PR strips the backend form building modules from Galaxy. These features are not used anymore by Galaxy but are embedded in the Toolshed which in some occasions re-uses makos within Galaxy. The solution suggested in this PR is to move form builders for select and checkbox fields to Toolshed makos and use the simple, non-html producing form objects of Galaxy. It also resolves the True=False issue related to Toolshed checkboxes. Now True equals True and False equals False. This PR is a prerequisite for the removal of the grid HTML builders. Once those are also moved to the Toolshed, Galaxy's backend will not create any HTML anymore.

@guerler guerler added this to the 18.01 milestone Dec 1, 2017

guerler added some commits Dec 1, 2017

@guerler guerler changed the title from [WIP] Remove html formbuilder from backend to Remove html formbuilder from backend Dec 9, 2017

@guerler guerler added status/review and removed status/WIP labels Dec 10, 2017

@guerler guerler requested a review from davebx Dec 10, 2017

@guerler

This comment has been minimized.

Contributor

guerler commented Dec 10, 2017

Thanks a lot for you help @davebx

@dannon dannon merged commit 7f30028 into galaxyproject:dev Dec 11, 2017

6 checks passed

api test Build finished. 334 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 60 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment