Remove html formbuilder from backend #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
remove_formbuilder
branch
2 times, most recently
from
1f7eee4
to
9b315cb
Compare
guerler
force-pushed
the
remove_formbuilder
branch
from
9b315cb
to
faf1c4f
Compare
guerler
changed the title
guerler
force-pushed
the
remove_formbuilder
branch
from
e1c73aa
to
9831980
Compare
|
Thanks a lot for you help @davebx |
martenson
added
kind/enhancement
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strips the backend form building modules from Galaxy. These features are not used anymore by Galaxy but are embedded in the Toolshed which in some occasions re-uses makos within Galaxy. The solution suggested in this PR is to move form builders for select and checkbox fields to Toolshed makos and use the simple, non-html producing form objects of Galaxy. It also resolves the
True=Falseissue related to Toolshed checkboxes. NowTrueequalsTrueandFalseequalsFalse. This PR is a prerequisite for the removal of the grid HTML builders. Once those are also moved to the Toolshed, Galaxy's backend will not create any HTML anymore.