Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks improvements #5164

Closed
wants to merge 3 commits into from
Closed

Webhooks improvements #5164

wants to merge 3 commits into from

Conversation

anatskiy
Copy link
Contributor

@anatskiy anatskiy commented Dec 8, 2017

This PR improves and simplifies the overall Webhooks' structure.

  1. All the webhook's files now are located in one folder (no more config, helper and static subfolders).
  2. Function Webhooks.load() is unified even more for all endpoints (e.g., onload, masthead, tool, etc.).
  3. Webhooks have a weight now (like it was explained here).
  4. Some of the logic has been moved to the client (like it was suggested here).

If you agree to the changes, I'll update the documentation accordingly.

P.S. Every single webhook is broken now. I've updated all the demo webhooks in this PR, but others won't work.

@martenson
Copy link
Member

@anatskiy This needs some de-conflicting, will you find time to do that?

@dannon
Copy link
Member

dannon commented Jan 19, 2018

(superseded by the rebased branch at #5342, testing/discussion/merging will continue there)

@dannon dannon closed this Jan 19, 2018
@anatskiy anatskiy deleted the webhooks_improvements branch July 15, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants