Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.01] fix for cases where panel elements have to_dict with different signature #5615

Merged
merged 3 commits into from Mar 1, 2018
Merged

[18.01] fix for cases where panel elements have to_dict with different signature #5615

merged 3 commits into from Mar 1, 2018

Commits on Mar 1, 2018

  1. fix for cases where panel elements have to_dict with different signature 

    we want to only cache Tools anyways, so this fixes other possible bug
where section/label etc would have same id as a Tool

change the detection of Tool object

to avoid circular import errors
Also use cache for dictifying sections, we should
gain more speed from that.
    @martenson
    martenson committed Mar 1, 2018
    Copy the full SHA
    d648e22 View commit details
    Browse the repository at this point in the history

  2. pass the toolbox obj to make sure cache is available

    @martenson
    martenson committed Mar 1, 2018
    Copy the full SHA
    5406a71 View commit details
    Browse the repository at this point in the history

  3. enable cache for tools that inherit from Tool

    @martenson
    martenson committed Mar 1, 2018
    Copy the full SHA
    b96fd2c View commit details
    Browse the repository at this point in the history