Python3: evict sgmllib and BeautifulSoup #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nsoranzo Thanks for picking this up and running with it! |
Broken in commit 66944ba .
Derive from HTMLParser instead of SGMLParser.
nsoranzo
changed the title
|
Ready for review and test (especially the part about pages). |
|
+1, my local pages are still working and it looks good to me. If something wonky pops up I'll be happy to help out. Thanks again for picking up this effort and finishing it off @nsoranzo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/microbes/_BaseHTMLProcessorclass (copied from feedparser) in_PageContentProcessorxref: #1715