New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable tool input datatype validation for dropped history items #5657
Conversation
I gave this a shot and this doesn't seem to allow dragging of HDA-type collection element into the toolform. It does allow dragging of HDCAs, so I guess something is still missing here for this to be equivalent to #5384 |
Alright, cool, thanks for reviewing it. |
Thanks again @guerler! |
Thanks @jmchilton, thanks @mvdbeek for working on this. |
I'm unable to get this work. The first dataset dropped in gets a name with "(hidden)" prepended, but the remaining datasets show up as "Dropped: XXXXXXXXXXXXXXXXXXX". Worse, I'm unable to run the tool and get the error: "The previously selected dataset has been deleted." Running 18.05. |
@mvdbeek @guerler @jmchilton Can someone confirm this works in some revision of release 18.05? I continue to get the error |
BTW, this is especially needed since file renaming ability was removed (renames now affect the collection, not the individual dataset) and it's therefore next to impossible to pull an item out of a collection and keep track of what it is (the element id is lost). |
This is equivalent to #5384. It disables the client-sided datatype input validation for items dropped from the history. Side effects include that dropped items may show the info label "unavailable" which previously indicated that a dataset is not available anymore. Additionally dropped items will be shown with preliminary attributes first before attributes can be updated through the backend. The consensus is that the benefit of dropping datasets contained in collections outweighs the disadvantages. ping @jmchilton. Can you help test this to make sure it behaves the same as #5384? Thanks in advance.