Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tool input datatype validation for dropped history items #5657

Merged
merged 5 commits into from Mar 20, 2018

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Mar 7, 2018

This is equivalent to #5384. It disables the client-sided datatype input validation for items dropped from the history. Side effects include that dropped items may show the info label "unavailable" which previously indicated that a dataset is not available anymore. Additionally dropped items will be shown with preliminary attributes first before attributes can be updated through the backend. The consensus is that the benefit of dropping datasets contained in collections outweighs the disadvantages. ping @jmchilton. Can you help test this to make sure it behaves the same as #5384? Thanks in advance.

@guerler guerler added this to the 18.05 milestone Mar 7, 2018
@mvdbeek
Copy link
Member

mvdbeek commented Mar 16, 2018

I gave this a shot and this doesn't seem to allow dragging of HDA-type collection element into the toolform. It does allow dragging of HDCAs, so I guess something is still missing here for this to be equivalent to #5384

@mvdbeek
Copy link
Member

mvdbeek commented Mar 16, 2018

Hmm, I tested this again on another instance and it does exactly what @guerler described. Went back to the other instance and here too this is working ... sorry for the noise @guerler. 👍 from me.

@guerler
Copy link
Contributor Author

guerler commented Mar 16, 2018

Alright, cool, thanks for reviewing it.

@mvdbeek mvdbeek merged commit 11b32f3 into galaxyproject:dev Mar 20, 2018
@mvdbeek
Copy link
Member

mvdbeek commented Mar 20, 2018

Thanks again @guerler!

@guerler
Copy link
Contributor Author

guerler commented Mar 20, 2018

Thanks @jmchilton, thanks @mvdbeek for working on this.

@lparsons
Copy link
Contributor

I'm unable to get this work. The first dataset dropped in gets a name with "(hidden)" prepended, but the remaining datasets show up as "Dropped: XXXXXXXXXXXXXXXXXXX". Worse, I'm unable to run the tool and get the error: "The previously selected dataset has been deleted." Running 18.05.

@lparsons
Copy link
Contributor

@mvdbeek @guerler @jmchilton Can someone confirm this works in some revision of release 18.05? I continue to get the error The previously selected dataset has been deleted. in the tool form (DESeq2). Do I need to update to dev (or better yet wait for 18.09?). Thx.

@lparsons
Copy link
Contributor

BTW, this is especially needed since file renaming ability was removed (renames now affect the collection, not the individual dataset) and it's therefore next to impossible to pull an item out of a collection and keep track of what it is (the element id is lost).

@guerler guerler deleted the disable_drop_validation branch February 19, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants