Avoid silent tool upgrades during workflow imports #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
exact_version_handling
branch
from
12dadec
to
bd7a71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are implicitly upgrading workflow modules with regard to tool versions during import and export. Upgrading means that the tool/module state is evaluated using a newer tool version. This can trigger a key error exception if the new tool version contains a grouping parameter which was not available previously. This PR resolves this, disabling tool version upgrades by default i.e. module states of mismatching tool versions are stored unmodified just as if the tool does not exist at all. In contrast, tool version upgrades are explicitly allowed when loading workflows into the editor or run view. In these two cases, missing conditional parameters are identified, corrected in memory and displayed with a warning. The stored module states remain unchanged unless they are actively overwritten by the workflow editor. Fixes #5617.