Rule builder styling fixes. #5909
Conversation
| @@ -338,7 +338,7 @@ | |||
| <button @click="resetRulesAndState" :title="titleReset" class="creator-reset-btn btn rule-btn-reset"> | |||
| {{ l("Reset") }} | |||
| </button> | |||
| <button @click="createCollection" :title="titleFinish" class="create-collection btn btn-primary rule-btn-okay" v-bind:class="{ disabled: !validInput }"> | |||
| <button @click="createCollection" :title="titleFinish" class="create-collection btn btn-secondary btn-primary" v-bind:class="{ disabled: !validInput }"> | |||
There was a problem hiding this comment.
having both btn-primary and btn-secondary classes on a button is superfluous I think
There was a problem hiding this comment.
disregard, was amended in subsequent commit
|
I am seeing really strange behavior when trying to define columns. The dropdown menu will intermittently not create a new row after click even though it goes through the 'active' state and closes. Sometimes it takes 4 attempts, other times it works on first, and even other times it just won't create the row ever (there is only so many times I can click). There is no js error.
|
|
@martenson Not just you - I see it too. Hmm.... |
|
That problem isn't this branch I don't think, it is dev. |
|
Looks like the fix is just to place the click handler on the outer li instead of the inner a target. Probably some spacing difference in Bootstrap 4 - makes sense that the tests wouldn't detect it since they literally click the a target. |
|
yeah bs4 wants to have |
|
Oh that probably explains the random really bright green in the downdown that is quite jarring also. I'll switch to use divs and a. |
|
@jmchilton no it does not, that is an actual change I made to increase contrast which is pretty bad by default in bs4. The color choice is weird on purpose, so I get feedback. ;) |
Gives more space for name and genome - dynamically resizes to space given with some reasonable minimum and maximum widths for widgets.
jmchilton
force-pushed
the
rule_builder_styling
branch
from
256b009
to
b59ea16
Compare
|
I opened a PR against your branch: jmchilton#66 with some UX improvements (I hope). The code has various MDN entry on |
|
In reoriented view the rules overflow into the input.
|
|
Merged your PR into #5940 and disabled the reorient mode - I don't think that was working out. I actually use the wider view of the rules in #5926 when there is not preview available but I think if there is tabular data that mode is always just awkward. I feel like all of the title and help elements I've added so far do show up in the GUI as mouseovers titles - but they could be more widespread and more prominent. The tooltips in the library GUI do look nicer than the browser mouseovers here. I'll see what what I can do. |
|
@martenson I've used bootstrap-vue to add many more tooltips and such to the rule builder in #5940, it made it very easy. |
|
@jmchilton marvelous! |
See commits for details - mix of BS4 fallout fixes and enhancements (including some requested by @martenson in #5822).