remove linting that broke the functionality of jstree module #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably this commit: galaxyproject@5cd3e3a putting it back to the former state, we did not write most of the code, we should not be linting it
martenson
changed the title
|
I would like to put htis file on linting blacklist but will await some feedback. ping @nsoranzo |
|
@martenson You're right, we shouldn't have linted this. Blacklist it, sounds good. |
|
Can we move all stuff like this that we didn't write and is licensed differently under a parent module (say galaxy.external) and blacklist that? |
nsoranzo
added a commit
that referenced
this pull request
Aug 19, 2015
remove linting that broke the functionality of jstree module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsequentially breaking everything that was using jstree as format in remote_files.py API controller
Probably broken in this commit: 5cd3e3a
I am putting it back to the former state. I also think that if we did not write most of the code, we should not be linting it.