[18.05] Remove defunct sharing column link #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
remove_defunct_link
branch
from
ff456ac
to
6702fa4
Compare
guerler
changed the title
|
@guerler The milestone set here was 18.09, but it's still targeting release_18.05; which one should it be? |
|
Thanks @dannon. Fixed the target. It would be most useful in 18.05, but its not a serious issue. |
jmchilton
approved these changes
May 26, 2018
|
@guerler thanks! sidenote: the milestone should be 18.09 in this case, since otherwise it wouldn't make it to any release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5025. This is a minor regression and has to be revisited when we transformed the grid components to vue. This should be handled at the front-end in the future. For now however this PR removes the useless link.