[release_15.07] Fix for valid height/width definitions in workflow rendering code, and fix identifiers. #625
Conversation
…enerating valid SVGs -- incorrect usage of arrow_end; this is intended to be a unique identifier for the element and not a boolean. This wasn't preventing render (on firefox or chrome) like the previous issue, but it would cause warnings.
|
This is actually targeting an issue found on both Galaxy and TS side. I have just seen this hapenning in an older Galaxy (GVL 3.04) and am trying to find what version is that. |
|
Yep, this code hasn't changed in a long time -- I think the problem is likely that chrome or firefox (or the underlying osx library?) just got way more strict w/ SVG parsing and what we were generating before was malformed in a couple ways. So, it's probably always been broken -- browsers just didn't care and handled it correctly until now. Just a theory, but all I can come up with right now :) |
|
That reasoning sounds legit. Seems like all of the browsers are depending on the same XML parsing library because Chrome, FF, Safari all have problems :) |
martenson
changed the title
|
👍 |
1 similar comment
|
👍 |
[release_15.07] Fix for valid height/width definitions in workflow rendering code, and fix identifiers.
|
Thanks for the merge. Per @martenson's suggestion on irc, I'm going to backport this to 15.01 and merge forward. |
This is a retarget of #624 because I can't PR correctly. Thanks @martenson.