Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for phenotype association tools #6269

Merged
merged 2 commits into from Jun 12, 2018
Merged

Fixes for phenotype association tools #6269

merged 2 commits into from Jun 12, 2018

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jun 4, 2018

  • Replace non-existent tab format with tabular in 2 tools
  • Remove deprecated interpreter attribute of <command>
  • Single-quote text and data parameters inside the command
  • Fix wrong name attribute of output in 3 tests
  • Linting and cleanups
  • Fix indentation

@nsoranzo
Replace non-existent tab format with tabular in 2 tools
f59b13c 
Also:
- Remove deprecated `interpreter` attribute of `<command>`
- Single-quote text and data parameters inside the command
- Fix wrong `name` attribute of `output` in 3 tests
- Linting and cleanups
@nsoranzo
Fix indentation
b454bef
@nsoranzo nsoranzo added this to the 18.09 milestone Jun 4, 2018
@mvdbeek mvdbeek merged commit 542dbe6 into galaxyproject:dev Jun 12, 2018
@nsoranzo nsoranzo deleted the phenotype_association_tools branch June 12, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/tools kind/bug
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nsoranzo @mvdbeek