Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.05] Add the canonical URL to grt config #6301

Merged
merged 1 commit into from Jun 7, 2018

Conversation

martenson
Copy link
Member

The base url you might be able to devise, but the /grt-admin/ part you probably wouldn't

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0 on this emotionally, but it doesn't hurt so approving. It's really GRT's fault if it provides you a configuration file that doesn't include the correct URL. (And during registration with GRT it provides you the filled out configuration file, so I'm just assuming it's a bug there / or in your copying rather than galaxy.)

@martenson
Copy link
Member Author

@erasche I think I understand but not every interaction with GRT starts at telescope.galaxyproject.org so the users coming from Galaxy should have a ready-to-go config. I think running own GRT is not a very probable scenario.

@hexylena
Copy link
Member

hexylena commented Jun 7, 2018

I think I understand but not every interaction with GRT starts at telescope.galaxyproject.org so the users coming from Galaxy should have a ready-to-go config

I was more coming from the thought that when users configure GRT, they'll talk to their GRT server (either from us or another one.) That server providers the grt.yml file for them to use (or at least copy the instance_id / api_key from). Even if that isn't our GRT, their GRT should still be showing them the correct URL to use.

I think running own GRT is not a very probable scenario.

Probably not, but I definitely wanted to make sure people didn't feel like it wasn't an option / wasn't a feature they could take advantage of unless they wanted to send us the data.

@martenson martenson merged commit 36fcb5c into galaxyproject:release_18.05 Jun 7, 2018
@nsoranzo nsoranzo changed the title [18.05] add the canonical url to grt config [18.05] Add the canonical url to grt config Oct 11, 2018
@nsoranzo nsoranzo changed the title [18.05] Add the canonical url to grt config [18.05] Add the canonical URL to grt config Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants