Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panel header margins in history and tool panel #6854

Merged
merged 4 commits into from Oct 11, 2018

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 11, 2018

Follow-up PR to fix header margins in panels and reduce white spaces.

untitled

@jxtx
Copy link
Contributor

jxtx commented Oct 11, 2018 via email

@martenson
Copy link
Member

fullscreen_10_11_18__12_02_pm

@guerler
Copy link
Contributor Author

guerler commented Oct 11, 2018

Thanks for pointing it out. It's a margin shift induced by the editable plugin. I fixed it by adding 1px margin to the element and updated the screenshot above. I think that this is a reasonable fix but it would be better to prevent the plugin from moving the element in the first place.

@martenson martenson merged commit b2477d1 into galaxyproject:dev Oct 11, 2018
@martenson
Copy link
Member

Thanks @guerler !

@guerler guerler deleted the styles-refresh-2018-panel-header branch February 19, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants