Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote tool testing enhancements #7167

Merged
merged 2 commits into from Jan 9, 2019

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Jan 3, 2019

I'll collect some things as I encounter them.

  • Allow passing in a test history. Otherwise you'll end up with one history per test, meaning > 1000 for a decent sized server if you're testing all tools
  • Fall back to local test data if Galaxy version isn't compatible with remote test data fetching/uploading
    - [ ] Hash and check if we already used the test data, avoids re-uploading same file over and over (not sure if in interactor or in ephemeris ...)
@mvdbeek mvdbeek changed the title [WIP] Remote tool testing enhancements Remote tool testing enhancements Jan 9, 2019
@galaxybot galaxybot added this to the 19.05 milestone Jan 9, 2019
@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jan 9, 2019

This is ready for review, and should be backported to 19.01, otherwise targeting external Galaxy < 19.01 with the galaxy interactor will fail.

@martenson martenson self-requested a review Jan 9, 2019
@martenson martenson merged commit dde3633 into galaxyproject:dev Jan 9, 2019
5 of 6 checks passed
5 of 6 checks passed
selenium test Build finished. 151 tests run, 3 skipped, 1 failed.
Details
api test Build finished. 448 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 285 tests run, 12 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
dannon added a commit that referenced this pull request Jan 10, 2019
[19.01] Backport #7167 - interactor improvements
@nsoranzo nsoranzo deleted the mvdbeek:verify_tool_improvements branch Jan 17, 2019
@jmchilton jmchilton modified the milestones: 19.05, 19.01 Feb 5, 2019
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Feb 5, 2019

Switched tag to 19.01 since it was backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.