Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip the client build in dockerized selenium tests #7280

Merged
merged 1 commit into from Jan 29, 2019

Conversation

nsoranzo
Copy link
Member

This allows the removal of the docker run of make client-production-maps, which was run on a docker image for the
wrong version of node.

Alternative to #7278 with the advantage of not having to remember to sync the node version in 2 places.

This allows the removal of the `docker run` of `make
client-production-maps`, which was run on a docker image for the
wrong version of `node`.
@nsoranzo
Copy link
Member Author

@galaxybot test py3

@dannon
Copy link
Member

dannon commented Jan 29, 2019

@mvdbeek @nsoranzo Argh, good catch -- thank you both. I was chasing a red herring looking at the chromedriver startup failures seen in the logs! I had completely forgotten that we set up this separate client-docker-build pipeline for selenium (we needed it in the days before Galaxy managed its own node/client stuff), and we do not need it anymore -- and it's best to test against the single pinned version specified in the galaxy common startup bit anyway.

@nsoranzo
Copy link
Member Author

Same number of failed Selenium tests here and in #7278, should be good to go.

@dannon
Copy link
Member

dannon commented Jan 29, 2019

@nsoranzo Yeah, that's what I was just looking at. Many of those pass locally for me, but this is a clear improvement and I can follow up looking into that separately. Going to go ahead and merge.

@dannon dannon merged commit 884c796 into galaxyproject:dev Jan 29, 2019
@nsoranzo nsoranzo deleted the selenium_client_build branch January 29, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants