Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip the client build in dockerized selenium tests #7280

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

commented Jan 29, 2019

This allows the removal of the docker run of make client-production-maps, which was run on a docker image for the
wrong version of node.

Alternative to #7278 with the advantage of not having to remember to sync the node version in 2 places.

Do not skip the client build in dockerized selenium tests
This allows the removal of the `docker run` of `make
client-production-maps`, which was run on a docker image for the
wrong version of `node`.

@nsoranzo nsoranzo added this to the 19.05 milestone Jan 29, 2019

@nsoranzo nsoranzo requested a review from mvdbeek Jan 29, 2019

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

@galaxybot test py3

@dannon

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@mvdbeek @nsoranzo Argh, good catch -- thank you both. I was chasing a red herring looking at the chromedriver startup failures seen in the logs! I had completely forgotten that we set up this separate client-docker-build pipeline for selenium (we needed it in the days before Galaxy managed its own node/client stuff), and we do not need it anymore -- and it's best to test against the single pinned version specified in the galaxy common startup bit anyway.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

Same number of failed Selenium tests here and in #7278, should be good to go.

@dannon

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@nsoranzo Yeah, that's what I was just looking at. Many of those pass locally for me, but this is a clear improvement and I can follow up looking into that separately. Going to go ahead and merge.

@dannon dannon merged commit 884c796 into galaxyproject:dev Jan 29, 2019

7 of 10 checks passed

selenium test python 3 Build finished. 151 tests run, 19 skipped, 26 failed.
Details
integration test python 3 Test started.
Details
selenium test Test started.
Details
api test Build finished. 449 tests run, 1 skipped, 0 failed.
Details
api test python 3 Build finished. 449 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
framework test python 3 Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 285 tests run, 12 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:selenium_client_build branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.