Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Range support #7323

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@pvanheus
Copy link
Contributor

commented Feb 7, 2019

Add note explaining that nginx sendfile support is required for Range (and thus IGV/JBrowse) to work.

Add note about Range support
Add note explaining that nginx sendfile support is required for Range (and thus IGV/JBrowse) to work.

@galaxybot galaxybot added the triage label Feb 7, 2019

@galaxybot galaxybot added this to the 19.05 milestone Feb 7, 2019

@erasche

erasche approved these changes Feb 7, 2019

@dannon dannon merged commit a1f188b into galaxyproject:dev Feb 7, 2019

4 of 5 checks passed

selenium test Build finished. 151 tests run, 3 skipped, 1 failed.
Details
api test Build finished. 450 tests run, 1 skipped, 0 failed.
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 285 tests run, 12 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still
check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.
Nginx can assume this task instead and as an added benefit, speed up downloads. In addition, both the IGV genome browser and JBrowse tool (run within Galaxy) require support for the HTTP *Range* header, and this is only available if nginx (or Apache
with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Feb 7, 2019

Member

I'd duplicate the added text in doc/source/admin/apache.md instead of mentioning (or Apache with sendfile support).

the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still
check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.
Nginx can assume this task instead and as an added benefit, speed up downloads. In addition, both the IGV genome browser and JBrowse tool (run within Galaxy) require support for the HTTP *Range* header, and this is only available if nginx (or Apache
with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Feb 7, 2019

Member
Suggested change
with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.
with sendfile support) serves datasets. This is accomplished through the use of the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it.
@dannon

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@nsoranzo Want to open a quick followup with those extra changes, or would you like for me to? +1 to both (looks like I merged this ~40 seconds before your review comments showed up! :))

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.