Add note about Range support #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note explaining that nginx sendfile support is required for Range (and thus IGV/JBrowse) to work.
hexylena
approved these changes
Feb 7, 2019
nsoranzo
reviewed
Feb 7, 2019
| the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still | ||
| check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. | ||
| Nginx can assume this task instead and as an added benefit, speed up downloads. In addition, both the IGV genome browser and JBrowse tool (run within Galaxy) require support for the HTTP *Range* header, and this is only available if nginx (or Apache | ||
| with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. |
There was a problem hiding this comment.
I'd duplicate the added text in doc/source/admin/apache.md instead of mentioning (or Apache with sendfile support).
| the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still | ||
| check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. | ||
| Nginx can assume this task instead and as an added benefit, speed up downloads. In addition, both the IGV genome browser and JBrowse tool (run within Galaxy) require support for the HTTP *Range* header, and this is only available if nginx (or Apache | ||
| with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. |
There was a problem hiding this comment.
Suggested change
| with sendfile support) serves datasets. This is accomplished through the use ofthe special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. | |
| with sendfile support) serves datasets. This is accomplished through the use of the special `X-Accel-Redirect` header. Dataset security is maintained in this configuration because nginx will still check with Galaxy to ensure that the requesting user has permission to access the dataset before sending it. |
|
@nsoranzo Want to open a quick followup with those extra changes, or would you like for me to? +1 to both (looks like I merged this ~40 seconds before your review comments showed up! :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note explaining that nginx sendfile support is required for Range (and thus IGV/JBrowse) to work.