Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.05] Add local namespaced resolver to default container resolvers #7896

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 6, 2019

The mulled container resolvers are building containers that are
namespaced to "local", so I think it makes a lot of sense to
include local in the defaults. This prevents planemo from
building the same image over and over again when run with
--mulled_containers / --biocontainers.

The mulled container resolvers are building containers that are
namespaced to "local", so I think it makes a lot of sense to
include local in the defaults. This prevents planemo from
building the same image over and over again when run with
`--biocontainers`.
@mvdbeek
Copy link
Member Author

mvdbeek commented May 6, 2019

As a sidenote I think we should use these options when testing IUC tools, but disable the biocontainer namespace so that we always test the latest version available in Conda.

@mvdbeek mvdbeek requested a review from jmchilton May 6, 2019 16:11
@jmchilton jmchilton merged commit 224f573 into galaxyproject:release_19.05 May 6, 2019
@jmchilton
Copy link
Member

I think this makes sense, thanks!

@galaxybot
Copy link
Contributor

This PR was merged without a milestone attached.

@nsoranzo nsoranzo deleted the add_local_namespace_cached_resolvers_to_default_resolver branch May 6, 2019 21:06
@nsoranzo nsoranzo added this to the 19.05 milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants