Remove unresolved function causing console error #8101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WilliamHolden No need to replace that ancient function, thanks for this cleanup. Failing test is unrelated. |
dannon
added
area/UI-UX
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 113 calls a function hoverImage which does not exist. This logic was changed in the past and the hoverImage function was removed. I removed the function for now since it's throwing a console error. Let me know if you prefer that I reimplement the function instead of just removing it. Old code can be seen here:
https://github.com/galaxyproject/galaxy/blob/release_18.09/client/galaxy/scripts/mvc/workflow/workflow-view-data.js