Fix job wrapper fail for queued jobs #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Jun 18, 2019
mvdbeek
force-pushed
the
fix_job_wrapper_fail
branch
from
75bb2e0
to
6fa2973
Compare
nsoranzo
reviewed
Jun 19, 2019
mvdbeek
force-pushed
the
fix_job_wrapper_fail
branch
from
46c1ed3
to
c3790a2
Compare
To provoke galaxyproject#8171 run the tests with GALAXY_CONFIG_OUTPUTS_TO_WORKING_DIRECTORY=True
when `outputs_to_working_directory` is set. Fixes galaxyproject#8171
This isn't needed when called by finish_job. Thanks Nicola!
mvdbeek
force-pushed
the
fix_job_wrapper_fail
branch
from
c3790a2
to
d0a48eb
Compare
nsoranzo
approved these changes
Jun 19, 2019
nsoranzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whose input datasets are purged. The error only occurs if
outputs_to_working_directoryis set.The new test then also revealed that we didn't properly pause jobs with inputs in error state (they'd just be ignored), which is fixed by 920925d