Fix small issues #8275
Merged
Fix small issues #8275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Jul 6, 2019
| } else { | ||
| inputFilled = false; | ||
| } | ||
| inputFilled = !!this._collectionAttached(); |
There was a problem hiding this comment.
Nice, didn't even know this one.
There was a problem hiding this comment.
Thanks for reviewing!
martenson
reviewed
Jul 6, 2019
martenson
reviewed
Jul 6, 2019
WilliamHolden
force-pushed
the
fix_small_issues
branch
from
d826957
to
a9257fa
Compare
martenson
added
kind/refactoring
|
Thanks @WilliamHolden ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some invalid code and simplifies the coding style.