Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for BootstrapVue Tables #8684

Merged
merged 7 commits into from Sep 20, 2019
Merged

Conversation

dannon
Copy link
Member

@dannon dannon commented Sep 20, 2019

WIP, going through and fixing up some invalid table field/slot definitions.

@guerler
Copy link
Contributor

guerler commented Sep 20, 2019

We should fix this also for Display Applications, another issue I noticed is that the modal for the Data dialog has no fixed height anymore.

@galaxybot galaxybot added this to the 20.01 milestone Sep 20, 2019
@dannon
Copy link
Member Author

dannon commented Sep 20, 2019

@guerler I'll check out Display Applications now. Not sure if the modal change is intentional and appropriate, or something that is no longer applied.

edit: Ahh, I see I fixed the fields but didn't notice the missing slot/button there, thanks!

@guerler guerler merged commit bae49ec into galaxyproject:dev Sep 20, 2019
@guerler
Copy link
Contributor

guerler commented Sep 20, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants