[15.10] Fix for no longer being able to access data managers.

[blankenberg]

Have datamanager links point to root with tool_id provided while targeting a new window.

tool_form.mako no longer exists and all tools have an empty string for their default_template value.

[martenson]

we have 10 more calls to controller='tool_runner' in the codebase (fulltext search), should we be concerned? ping @guerler

[blankenberg]

There is a hard coded check for 'default' against tool.type in the controller method. Any tool that is not a default tool will probably fail to load against tool_runner index/default (rerun should be OK).

[blankenberg]

I'm not super happy with using a new window, but showing only the tool form (within the admin iframe) without panels seemed problematic.

[martenson]

👍 for this as a hotfix; is there an easy way how to make this work nicer @guerler ?
If not I guess admins can chew through the new window. :)

[dannon]

Is the Galaxy.app.display functionality available from within the admin context? And, can the data managers be rendered using the js tool form?

If so, it should be pretty straightforward to use the Galaxy.app.display function with some appropriate target (the right hand admin frame), and use the new tool form javascript.

(then again, that seems like a whole lot of enhancement work and this works for now -- +1 and merging)