Add postcss-loader and autoprefixer dependencies #8821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some of the bootstrap components were not rendering correctly and had some inconsistencies between browsers. I tracked it down to the fact that we are not using an autoprefixer. This pull request adds the post-css and autoprefixer dependencies so that bootstrap works properly on all browsers. This prefixer is recommended by Google and used in Twitter and Alibaba. The autoprefixer is also listed in the minimal setup requirements for bootstrap in the documentation here:
https://getbootstrap.com/docs/4.0/getting-started/webpack/
Ironically I also noticed an error in the bootstrap documentation which states that you should also include
require('precss')
in the loader. I was skeptical that we needed that module so I researched and found the following PR(removing the precss requirement) into the Bootstrap repo which for some reason they never merged even though it was approved by one of the developers twbs/bootstrap#24671.