Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General server dependency updates (was/including catalina fix) #8843

Merged
merged 6 commits into from Oct 23, 2019

Conversation

dannon
Copy link
Member

@dannon dannon commented Oct 22, 2019

This started as an update to cryptography (the first commit here, which does fix startup on Catalina), but I decided that this early in the cycle would be a good time to do a full-pass update as well. The first commit has been backported to 19.05 in #8845

…startups on catalina to fail (though I don't know exactly why)
@galaxybot galaxybot added this to the 20.01 milestone Oct 22, 2019
@dannon dannon changed the title Cryptography update; this turns out to be the culprit causing python … Dependency update (was catalina fix) Oct 22, 2019
@dannon dannon changed the title Dependency update (was catalina fix) General server dependency updates (was catalina fix) Oct 22, 2019
@dannon dannon changed the title General server dependency updates (was catalina fix) General server dependency updates (was/including catalina fix) Oct 22, 2019
@@ -70,7 +70,7 @@ bioblend = "*"
boto = "*"
kombu = "*"
psutil = "*"
pulsar-galaxy-lib = ">=0.14.0.dev1"
pulsar-galaxy-lib = "==0.14.0.dev1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary because of a pipenv issue: pypa/pipenv#3928

- Avoid repeating the package name in sed regexp replacements.
- More dependency updates.
@nsoranzo
Copy link
Member

nsoranzo commented Oct 23, 2019

I just noticed that #8543 added 2 new dependencies to the Pipfile without running make update-dependencies: https://github.com/galaxyproject/galaxy/pull/8543/files#r338021231

This is now adding 9 new dependencies which I think may be not used: markdown, weasyprint, CairoSVG, Pyphen, cairocffi, cssselect2, html5lib, pdfrw and tinycss2.

@nsoranzo nsoranzo merged commit 6257604 into galaxyproject:dev Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants