[20.01] Prevent caching of bootstrapped client data #9294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Feb 1, 2020
| @@ -276,6 +276,10 @@ def client(self, trans, **kwd): | |||
| return self._bootstrapped_client(trans, **kwd) | |||
|
|
|||
| def _bootstrapped_client(self, trans, app_name='analysis', **kwd): | |||
| # This includes contextualized user options in the bootstrapped data; we don't want to cache it. | |||
| trans.response.headers['Cache-Control'] = ['no-cache', 'no-store', 'must-revalidate'] | |||
There was a problem hiding this comment.
Might make sense to consolidate this in a decorator (in dev) ? We do this in a couple of places.
There was a problem hiding this comment.
Yep, I actually started doing exactly that yesterday, but for a separate PR for dev
|
Merged forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to address the last bits of #7249
The javascript itself can/will still be cached, and that's the brunt of the data transmitted when filling out the app. The majority of this particular response is the bootstrapped data related primarily to current user that we don't really want to cache.