[20.01] Rename galaxy.util.logging to galaxy.util.custom_logging #9705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise there may be import issues:
```
==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
.tox/py27-unit/lib/python2.7/site-packages/py/_path/common.py:383: in visit
for x in Visitor(fil, rec, ignore, bf, sort).gen(self):
.tox/py27-unit/lib/python2.7/site-packages/py/_path/common.py:425: in gen
if p.check(dir=1) and (rec is None or rec(p))])
.tox/py27-unit/lib/python2.7/site-packages/_pytest/main.py:667: in _recurse
ihook = self.gethookproxy(dirpath)
.tox/py27-unit/lib/python2.7/site-packages/_pytest/main.py:482: in gethookproxy
my_conftestmodules = pm._getconftestmodules(fspath)
.tox/py27-unit/lib/python2.7/site-packages/_pytest/config/__init__.py:424: in _getconftestmodules
mod = self._importconftest(conftestpath.realpath())
.tox/py27-unit/lib/python2.7/site-packages/_pytest/config/__init__.py:463: in _importconftest
raise ConftestImportFailure(conftestpath, sys.exc_info())
E ConftestImportFailure: (local('/home/circleci/repo/test/unit/queue_worker/conftest.py'), (<type 'exceptions.AttributeError'>, AttributeError("'module' object has no attribute 'getLogger'",), <traceback object at 0x7fabd96b7eb0>))
----- generated html file: file:///home/circleci/repo/run_unit_tests.html ------
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 1.83 seconds ============================
```
mvdbeek
force-pushed
the
fix_unit_test_error
branch
from
8f49261
to
f6a79f6
Compare
jmchilton
approved these changes
May 4, 2020
nsoranzo
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming packages like standard library packages is not a good idea.
These errors just cropped up in #9699 (although I have no idea why this wasn't an error before).