[20.01] Check dataset is accessible and use payload in job error API #9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
force-pushed
the
release_20.01_fix_jobs_error_api
branch
from
78cf3c4
to
d308c03
Compare
nsoranzo
commented
May 12, 2020
nsoranzo
force-pushed
the
release_20.01_fix_jobs_error_api
branch
from
d308c03
to
070fb67
Compare
|
Green and ready to review! |
mvdbeek
reviewed
May 13, 2020
mvdbeek
approved these changes
May 13, 2020
Without the `payload` parameter, it cannot be correctly used by BioBlend. Also: - `self.decode_id()` already raise a `MalformedId` exception - Use `RequestParameterMissingException` instead of `ObjectAttributeMissingException` when no object is to be created - Prevent a `KeyError` exception if `dataset_id` is missing from the payload - Check that the dataset is an output of the job
We cannot be sure that the response is valid JSON if there was an error. Also do not use mutable data structures for argument defaults. Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
nsoranzo
force-pushed
the
release_20.01_fix_jobs_error_api
branch
from
840c3ae
to
0de3051
Compare
mvdbeek
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
payloadparameter, it cannot be correctly used by BioBlend.Also:
self.decode_id()already raise aMalformedIdexceptionRequestParameterMissingExceptioninstead ofObjectAttributeMissingExceptionwhen no object is to be createdKeyErrorexception ifdataset_idis missing from the payload