Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.01] Cookie names to work with PR #9921 and py3 Exception printing #9991

Merged
merged 2 commits into from Jul 14, 2020

Conversation

almahmoud
Copy link
Member

Nonce mismatch error was occurring when logging in with OIDC (Keycloak). Noticed that the nonce cookie was returning None, and then Dannon informed me that galaxy- prefix is needed for cookie names after #9921.
Also, when the error was occurring, a subsequent error was happening when trying to print e.message because of changes to Exception in py3, so changed that as well.

This should also be ported to 20.05

@almahmoud almahmoud changed the title Cookie names to work with PR #9921 and py3 Exception printing [20.01] Cookie names to work with PR #9921 and py3 Exception printing Jul 13, 2020
@almahmoud almahmoud requested a review from dannon July 13, 2020 22:03
Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this should work with the new cookie handling. Thanks!

@dannon dannon merged commit 2145f82 into galaxyproject:release_20.01 Jul 14, 2020
@galaxybot
Copy link
Contributor

This PR was merged without a milestone attached.

@nsoranzo nsoranzo added the area/python3 Specific to Python 3 label Jul 14, 2020
@nsoranzo nsoranzo added this to the 20.09 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/python3 Specific to Python 3 kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants