Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive shed uploads die if yaml is invalid rather than emitting error #114

Closed
hexylena opened this issue Apr 6, 2015 · 3 comments · Fixed by #173
Closed

Recursive shed uploads die if yaml is invalid rather than emitting error #114

hexylena opened this issue Apr 6, 2015 · 3 comments · Fixed by #173
Assignees
@hexylena
Labels
bug

Comments

@hexylena
Copy link
Member

hexylena commented Apr 6, 2015

No description provided.

@hexylena hexylena self-assigned this Apr 6, 2015
@hexylena hexylena added the bug label Apr 6, 2015
@jmchilton
Copy link
Member

Stealing this issue from you @erasche - going to work on a fix for this and @peterjc's issue with noisy exceptions in #158.

@hexylena
Copy link
Member Author

hexylena commented May 1, 2015

Please!

jmchilton added a commit to jmchilton/planemo that referenced this issue May 1, 2015
@jmchilton
Exception handling improvements.
1b0d417 
For shed operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Clean up noisy exception reported by @peterjc @ galaxyproject#158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes galaxyproject#114.
@jmchilton jmchilton mentioned this issue May 1, 2015
Merged
jmchilton added a commit to jmchilton/planemo that referenced this issue May 1, 2015
@jmchilton
Exception handling improvements.
94459de 
For shed operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Clean up noisy exception reported by @peterjc @ galaxyproject#158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes galaxyproject#114.
jmchilton added a commit to jmchilton/planemo that referenced this issue May 1, 2015
@jmchilton
Exception handling improvements.
a6f6c65 
For shed operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Clean up noisy exception reported by @peterjc @ galaxyproject#158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes galaxyproject#114.
@peterjc
Copy link
Contributor

peterjc commented May 1, 2015

This looks like a good idea (not tried it yet) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hexylena hexylena

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exception handling improvements. jmchilton/planemo
3 participants
@peterjc @jmchilton @hexylena