New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling improvements. #173

Merged
merged 1 commit into from May 1, 2015

Conversation

Projects
None yet
1 participant
@jmchilton
Copy link
Member

jmchilton commented May 1, 2015

For shed_* operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Covers at least problems with realization such as invalid .shed.yml contents and missing includes.

Clean up noisy exception reported by @peterjc @ #158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes #114.

@jmchilton jmchilton force-pushed the jmchilton:exception_improvements branch from 1b0d417 to 94459de May 1, 2015

Exception handling improvements.
For shed operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Clean up noisy exception reported by @peterjc @ #158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes #114.

@jmchilton jmchilton force-pushed the jmchilton:exception_improvements branch from 94459de to a6f6c65 May 1, 2015

jmchilton added a commit that referenced this pull request May 1, 2015

Merge pull request #173 from jmchilton/exception_improvements
Exception handling improvements.

@jmchilton jmchilton merged commit 33a1a40 into galaxyproject:master May 1, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment