Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upException handling improvements. #173
Conversation
jmchilton
force-pushed the
jmchilton:exception_improvements
branch
from
1b0d417
to
94459de
May 1, 2015
jmchilton
force-pushed the
jmchilton:exception_improvements
branch
from
94459de
to
a6f6c65
May 1, 2015
added a commit
that referenced
this pull request
May 1, 2015
jmchilton
merged commit 33a1a40
into
galaxyproject:master
May 1, 2015
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jmchilton commentedMay 1, 2015
For
shed_*
operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new--fail_fast
option.Covers at least problems with realization such as invalid
.shed.yml
contents and missing includes.Clean up noisy exception reported by @peterjc @ #158 (comment) (unless
--fail_fast
is used - then you get the full stack trace).Tests.
Fixes #114.