Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling improvements. #173

Merged
merged 1 commit into from
May 1, 2015

Conversation

jmchilton
Copy link
Member

For shed_* operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Covers at least problems with realization such as invalid .shed.yml contents and missing includes.

Clean up noisy exception reported by @peterjc @ #158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes #114.

For shed operations - catch exceptions, log them, but continue to completion and then return a 254 exit code at the end indicating there were problems with one or more repositories. This behavior has can be disabled with any of the shed operations using the new --fail_fast option.

Clean up noisy exception reported by @peterjc @ galaxyproject#158 (comment) (unless --fail_fast is used - then you get the full stack trace).

Tests.

Fixes galaxyproject#114.
jmchilton added a commit that referenced this pull request May 1, 2015
@jmchilton jmchilton merged commit 33a1a40 into galaxyproject:master May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursive shed uploads die if yaml is invalid rather than emitting error
1 participant