Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas validity error with lint #622

Closed
pkrog opened this issue Jan 30, 2017 · 6 comments
Closed

Schemas validity error with lint #622

pkrog opened this issue Jan 30, 2017 · 6 comments

Comments

@pkrog
Copy link

pkrog commented Jan 30, 2017

When running planemo lint on my tool XML, I got this error:
element param: Schemas validity error : Element 'param', attribute 'refresh_on_change': The attribute 'refresh_on_change' is not allowed.
It seems the current galaxy.xsd does not define refresh_on_change as a valid attribute for param element.

@pkrog
Copy link
Author

pkrog commented Jan 30, 2017

After running the tests of the project Galaxy-XSD, I see that there are many errors.
Maybe it would be better to turn off xsd by default in planemo lint.

@pkrog
Copy link
Author

pkrog commented Jan 30, 2017

I've seen that Galaxy-XSD has been move into Galaxy.
However even here the galaxy.xsd file does not contain definition for refresh_on_change .

@peterjc
Copy link
Contributor

peterjc commented Jan 30, 2017

In this case, we need to file a bug on Galaxy itself for missing refresh_on_change in the XSD file https://github.com/galaxyproject/galaxy/tree/dev/lib/galaxy/tools/xsd (Planemo just bundles a copy of this file).

Please do report any other XSD issues as given how the tool XML format evolved there are potentially other rarely used tags which have not been defined.

You can turn off the XSD changing with planemo lint --no_xsd.

@bgruening
Copy link
Member

I'm not sure, but it can be that refresh_on_change has no effect anymore? @pierrickrogermele are you sure you still need it?

@pkrog
Copy link
Author

pkrog commented Jan 30, 2017

@bgruening, I use this refresh_on_change attribute in coordination with the code tag, which is deprecated.
However I've not seen any replacement for the code tag, and I really need it in order to display choice list from a database or a file.
The refresh_on_change attribute is not listed itself in the schema, but it is used inside an example.

@jmchilton
Copy link
Member

I'll update the schema to include refresh_on_change - it does seem to do something.

⚡ grep -r "refresh_on_change" client/galaxy 
...
client/galaxy/scripts/mvc/form/form-view.js:                if ( !input || input.refresh_on_change || self.options.always_refresh ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants