Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allways use random id_secret for testing #1198

Merged
merged 6 commits into from
Nov 15, 2021

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Oct 20, 2021

Fix galaxyproject/planemo-ci-action#18

As far as I can see this is then set as 'GALAXY_CONFIG_OVERRIDE_ID_SECRET' in the env over here:

env = _build_env_for_galaxy(properties, template_args)

  • The first two commits implement setting --id_secret on the CLI, ie. the user needs to generate the secret on its own.
  • Then I thought it might be more user friendly to generate the random hash automatically.
  • Finally as suggested by @nsoranzo changed to always setting a random secret

I'm not 100% sure if Galaxy actually uses the env variable .. any idea how to test this?

@bernt-matthias bernt-matthias changed the title Topic/id secret Allow test to use random id_secret Oct 20, 2021
@nsoranzo
Copy link
Member

I don't think we need an option for this, we should just always generate a random id_secret.

@bernt-matthias
Copy link
Contributor Author

I don't think we need an option for this, we should just always generate a random id_secret.

Good idea. Then we also need no change to the planemo-ci-action.

@bernt-matthias bernt-matthias changed the title Allow test to use random id_secret Allways use random id_secret for testing Oct 20, 2021
@bernt-matthias
Copy link
Contributor Author

Thanks for your approval @jmchilton . After rebasing also tests seem to pass now.

@bgruening bgruening merged commit 008cb08 into galaxyproject:master Nov 15, 2021
@bgruening
Copy link
Member

Thanks @bernt-matthias!

@bernt-matthias bernt-matthias deleted the topic/id_secret branch March 14, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate random id_secret
4 participants